improve alert message from pump and acknowledge in all cases

FreeAPS/Sources/APS/APSManager.swift

@@ -35,6 +35,7 @@ enum APSError: LocalizedError {
     case glucoseError(message: String)
     case apsError(message: String)
     case deviceSyncError(message: String)
+    case deviceAlert(message: String)
 
     var errorDescription: String? {
         switch self {
@@ -48,6 +49,8 @@ enum APSError: LocalizedError {
             return "APS error: \(message)"
         case let .deviceSyncError(message):
             return "Sync error: \(message)"
+        case let .deviceAlert(message):
+            return "Pump message: \(message)"
         }
     }
 }

FreeAPS/Sources/APS/DeviceDataManager.swift

@@ -432,6 +432,8 @@ extension BaseDeviceDataManager: DeviceManagerDelegate {
     func issueAlert(_ alert: Alert) {
         if !alertStore.contains(where: { $0.identifier.alertIdentifier == alert.identifier.alertIdentifier }) {
             alertStore.append(alert)
+            let infoMessage = APSError.deviceAlert(message: alert.foregroundContent!.body)
+            errorSubject.send(infoMessage)
             broadcaster.notify(pumpNotificationObserver.self, on: processQueue) {
                 $0.pumpNotification(alert: alert)
             }

FreeAPS/Sources/Services/UserNotifiactions/UserNotificationsManager.swift

@@ -418,10 +418,11 @@ extension BaseUserNotificationsManager: pumpNotificationObserver {
                 deleteOld: true,
                 trigger: nil
             )
-            self.apsManager.pumpManager?.acknowledgeAlert(alertIdentifier: alert.identifier.alertIdentifier) { error in
-                if let error = error {
-                    debug(.deviceManager, "acknowledge not succeeded with error \(error.localizedDescription)")
-                }
+        }
+        // Acknowledge in all case the alert to stop beep (in particular)
+        apsManager.pumpManager?.acknowledgeAlert(alertIdentifier: alert.identifier.alertIdentifier) { error in
+            if let error = error {
+                debug(.deviceManager, "acknowledge not succeeded with error \(error.localizedDescription)")
             }
         }
     }