Explorar o código

Avoid double saving

(cherry picked from commit ce6081e2c282346715bf7c5813e2d070e138a9dc)
Jon Mårtensson %!s(int64=2) %!d(string=hai) anos
pai
achega
91f79c225f

+ 0 - 2
FreeAPS/Sources/APS/Storage/GlucoseStorage.swift

@@ -71,11 +71,9 @@ final class BaseGlucoseStorage: GlucoseStorage, Injectable {
                 if bg_ != 0 {
                     self.coredataContext.perform {
                         let dataForForStats = Readings(context: self.coredataContext)
-
                         dataForForStats.date = bgDate
                         dataForForStats.glucose = Int16(bg_)
                         dataForForStats.id = id
-
                         try? self.coredataContext.save()
                     }
                 }

+ 1 - 11
FreeAPS/Sources/Modules/DataTable/DataTableStateModel.swift

@@ -142,7 +142,6 @@ extension DataTable {
             let fetchRequest: NSFetchRequest<NSFetchRequestResult>
             fetchRequest = NSFetchRequest(entityName: "Readings")
             fetchRequest.predicate = NSPredicate(format: "id == %@", id)
-
             let deleteRequest = NSBatchDeleteRequest(
                 fetchRequest: fetchRequest
             )
@@ -158,7 +157,7 @@ extension DataTable {
             } catch {
                 // To do: handle any thrown errors.
             }
-            try? coredataContext.save()
+            // try? coredataContext.save()
         }
 
         func addManualGlucose() {
@@ -179,15 +178,6 @@ extension DataTable {
             )
             provider.glucoseStorage.storeGlucose([saveToJSON])
             debug(.default, "Manual Glucose saved to glucose.json")
-
-            coredataContext.perform {
-                let saveToCoreData = Readings(context: self.coredataContext)
-                saveToCoreData.date = now
-                saveToCoreData.glucose = Int16(Int(glucose))
-                saveToCoreData.id = id
-                try? self.coredataContext.save()
-                debug(.default, "Manual Glucose saved to CoreData")
-            }
         }
     }
 }