feat(algo): Update error conditions for early exits; remove 400 dosing guard #588

Trio/Sources/APS/OpenAPS/OpenAPS.swift

@@ -454,8 +454,7 @@ final class OpenAPS {
                 start: (activeOverrides.first?.start ?? 0) as Decimal,
                 end: (activeOverrides.first?.end ?? 0) as Decimal,
                 smbMinutes: activeOverrides.first?.smbMinutes?.decimalValue ?? maxSMBBasalMinutes,
-                uamMinutes: activeOverrides.first?.uamMinutes?.decimalValue ?? maxUAMBasalMinutes,
-                shouldProtectDueToHIGH: GlucoseStored.glucoseIsHIGH(glucose)
+                uamMinutes: activeOverrides.first?.uamMinutes?.decimalValue ?? maxUAMBasalMinutes
             )
 
             // Save and return contents of Trio's custom oref variables

Trio/Sources/APS/OpenAPSSwift/DetermineBasal/DetermineBasalGenerator.swift

@@ -535,15 +535,14 @@ enum DeterminationGenerator {
             glucose == 38 ||
             noise >= 3 ||
             minAgo > 12 ||
-            minAgo < -5 ||
-            (shortAvgDelta == 0 && longAvgDelta == 0)
+            minAgo < -5
 
         // === IF ERROR, CANCEL/SHORTEN TEMPS ===
         guard errorDetected, let currentTemp = currentTemp else { return nil }
 
-        if currentTemp.rate >= basal {
-            // Cancel high temp: set 0U/hr for 0m (neutralizes)
-            let reasonWithAction = reason + ". Canceling high temp basal of \(currentTemp.rate)U/hr."
+        if currentTemp.rate >= basal { // high temp is running
+            // Replace high temp with neutral temp at scheduled basal rate for 30min
+            let reasonWithAction = reason + ". Replacing high temp basal of \(currentTemp.rate)U/hr with neutral temp of \(basal)U/hr"
             return Determination(
                 id: UUID(),
                 reason: reasonWithAction,
@@ -551,8 +550,8 @@ enum DeterminationGenerator {
                 insulinReq: nil,
                 eventualBG: nil,
                 sensitivityRatio: nil,
-                rate: 0,
-                duration: 0,
+                rate: basal,
+                duration: 30,
                 iob: nil,
                 cob: nil,
                 predictions: nil,

Trio/Sources/APS/OpenAPSSwift/DetermineBasal/DosingEngine.swift

@@ -30,10 +30,6 @@ enum DosingEngine {
             return false
         }
 
-        if trioCustomOrefVariables.shouldProtectDueToHIGH {
-            return false
-        }
-
         if !profile.allowSMBWithHighTemptarget, profile.temptargetSet == true, adjustedTargetGlucose > 100 {
             return false
         }

Trio/Sources/Models/TrioCustomOrefVariables.swift

@@ -21,7 +21,6 @@ struct TrioCustomOrefVariables: JSON, Equatable {
     var end: Decimal
     var smbMinutes: Decimal
     var uamMinutes: Decimal
-    var shouldProtectDueToHIGH: Bool
 
     init(
         average_total_data: Decimal,
@@ -43,8 +42,7 @@ struct TrioCustomOrefVariables: JSON, Equatable {
         start: Decimal,
         end: Decimal,
         smbMinutes: Decimal,
-        uamMinutes: Decimal,
-        shouldProtectDueToHIGH: Bool
+        uamMinutes: Decimal
     ) {
         self.average_total_data = average_total_data
         self.weightedAverage = weightedAverage
@@ -66,7 +64,6 @@ struct TrioCustomOrefVariables: JSON, Equatable {
         self.end = end
         self.smbMinutes = smbMinutes
         self.uamMinutes = uamMinutes
-        self.shouldProtectDueToHIGH = shouldProtectDueToHIGH
     }
 }
 
@@ -92,6 +89,5 @@ extension TrioCustomOrefVariables {
         case end
         case smbMinutes
         case uamMinutes
-        case shouldProtectDueToHIGH
     }
 }

TrioTests/OpenAPSSwiftTests/DetermineBasalEarlyExitTests.swift

@@ -113,8 +113,7 @@ import Testing
             start: 0,
             end: 0,
             smbMinutes: 30,
-            uamMinutes: 30,
-            shouldProtectDueToHIGH: false
+            uamMinutes: 30
         )
 
         return (

TrioTests/OpenAPSSwiftTests/DetermineBasalEnableSmbTests.swift

@@ -64,8 +64,7 @@ import Testing
             start: 0,
             end: 0,
             smbMinutes: 0,
-            uamMinutes: 0,
-            shouldProtectDueToHIGH: false
+            uamMinutes: 0
         )
 
         return (
@@ -110,21 +109,6 @@ import Testing
         #expect(decision.isEnabled == false)
     }
 
-    @Test("Should disable SMB when shouldProtectDueToHIGH is true") func disableWhenProtectDueToHigh() throws {
-        var inputs = createDefaultInputs()
-        inputs.trioCustomOrefVariables.shouldProtectDueToHIGH = true
-        inputs.profile.enableSMBAlways = true // Ensure protection takes precedence
-
-        let decision = try DosingEngine.makeSMBDosingDecision(
-            profile: inputs.profile, meal: inputs.meal, currentGlucose: inputs.currentGlucose,
-            adjustedTargetGlucose: inputs.adjustedTargetGlucose,
-            minGuardGlucose: inputs.minGuardGlucose,
-            threshold: inputs.threshold, glucoseStatus: inputs.glucoseStatus,
-            trioCustomOrefVariables: inputs.trioCustomOrefVariables, clock: inputs.clock
-        )
-        #expect(decision.isEnabled == false)
-    }
-
     @Test("Should disable SMB with high temp target when not allowed") func disableWithHighTempTarget() throws {
         var inputs = createDefaultInputs()
         inputs.profile.allowSMBWithHighTemptarget = false

TrioTests/OpenAPSSwiftTests/DynamicISFTests.swift

@@ -55,8 +55,7 @@ import Testing
             start: 0,
             end: 0,
             smbMinutes: 30,
-            uamMinutes: 30,
-            shouldProtectDueToHIGH: false
+            uamMinutes: 30
         )
 
         return (profile, preferences, glucose, trioVars)