Replace upload calls in FetchGlucoseManager with Combine subscriptions in Remote Service Managers

FreeAPS/Sources/APS/FetchGlucoseManager.swift

@@ -263,17 +263,6 @@ final class BaseFetchGlucoseManager: FetchGlucoseManager, Injectable {
 
         deviceDataManager.heartbeat(date: Date())
 
-        // Upload to NS/Health/Tidepool
-        Task.detached {
-            async let uploadToNS: () = self.nightscoutManager.uploadGlucose()
-            async let uploadToHealth: () = self.healthKitManager.uploadGlucose()
-            async let uploadToTidepool: () = self.tidepoolService.uploadGlucose()
-
-            await uploadToNS
-            await uploadToHealth
-            await uploadToTidepool
-        }
-
         // End of the Background tasks
         if let backgroundTask = backGroundFetchBGTaskID {
             UIApplication.shared.endBackgroundTask(backgroundTask)

FreeAPS/Sources/Services/HealthKit/HealthKitManager.swift

@@ -72,6 +72,16 @@ final class BaseHealthKitManager: HealthKitManager, Injectable {
                 .share()
                 .eraseToAnyPublisher()
 
+        glucoseStorage.updatePublisher
+            .receive(on: DispatchQueue.global(qos: .background))
+            .sink { [weak self] _ in
+                guard let self = self else { return }
+                Task {
+                    await self.uploadGlucose()
+                }
+            }
+            .store(in: &subscriptions)
+
         registerHandlers()
 
         guard isAvailableOnCurrentDevice,

FreeAPS/Sources/Services/Network/NightscoutManager.swift

@@ -85,6 +85,16 @@ final class BaseNightscoutManager: NightscoutManager, Injectable {
                 .share()
                 .eraseToAnyPublisher()
 
+        glucoseStorage.updatePublisher
+            .receive(on: DispatchQueue.global(qos: .background))
+            .sink { [weak self] _ in
+                guard let self = self else { return }
+                Task {
+                    await self.uploadGlucose()
+                }
+            }
+            .store(in: &subscriptions)
+
         registerHandlers()
         setupNotification()
     }

FreeAPS/Sources/Services/Network/TidepoolManager.swift

@@ -55,6 +55,16 @@ final class BaseTidepoolManager: TidepoolManager, Injectable {
                 .share()
                 .eraseToAnyPublisher()
 
+        glucoseStorage.updatePublisher
+            .receive(on: DispatchQueue.global(qos: .background))
+            .sink { [weak self] _ in
+                guard let self = self else { return }
+                Task {
+                    await self.uploadGlucose()
+                }
+            }
+            .store(in: &subscriptions)
+
         registerHandlers()
 
         subscribe()