Преглед изворни кода

Skip volume-button stop teardown when monitoring was never started (#612)

Previously alarmStopped() always logged "Alarm stop detected" under the
Volume Button Snooze category and ran the teardown, even when the
volume-button-snooze feature was disabled and the matching
alarmStarted() had early-returned. The result was a misleading log line
on every alarm event for users who don't use volume-button snooze.

Guard alarmStopped() on isMonitoring so it only runs when the volume
observer was actually started. The "Invalidating volume observer." log
inside stopMonitoring() now serves as the single, accurate teardown
entry.
Jonas Björkert пре 3 месеци
родитељ
комит
edf5996a93
1 измењених фајлова са 1 додато и 1 уклоњено
  1. 1 1
      LoopFollow/Controllers/VolumeButtonHandler.swift

+ 1 - 1
LoopFollow/Controllers/VolumeButtonHandler.swift

@@ -106,7 +106,7 @@ class VolumeButtonHandler: NSObject {
     }
 
     private func alarmStopped() {
-        LogManager.shared.log(category: .volumeButtonSnooze, message: "Alarm stop detected")
+        guard isMonitoring else { return }
 
         alarmStartTime = nil
         stopMonitoring()